Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

CLA check failed - "Error: The service is currently unavailable." #147

Open
OmarShehata opened this issue Sep 11, 2020 · 4 comments
Open

Comments

@OmarShehata
Copy link
Contributor

The CLA check failed today here CesiumGS/cesium#9147 (comment) with the following error:

Error: The service is currently unavailable.

I believe this is an error returned from the Google Sheets API.

@OmarShehata
Copy link
Contributor Author

It may just be a fluke because the CLA check is working again now: CesiumGS/cesium#9148 (comment). Not sure if there's any other action that can be taken here other than making the error thrown more description, like, prefixing it with "Failed while trying to fetch individual CLA google sheet" or something.

@mramato
Copy link
Contributor

mramato commented Sep 11, 2020

Do we retry on a failed request? or do we just try once and give up? Almost all kinds of network communication like this uses a retry/exponential backoff strategy.

@OmarShehata
Copy link
Contributor Author

We do not currently retry on CLA failure: https://github.com/CesiumGS/cesium-concierge/blob/master/lib/commentOnOpenedPullRequest.js#L165.

This just happened again here: CesiumGS/cesium#9161 (comment). It should be easy to add a retry after 1 second, 2 second, 4 etc and give up after X attempts.

@ptrgags
Copy link

ptrgags commented Sep 27, 2021

Noticing this again here: CesiumGS/cesium#9826 (comment) -- talking with @lilleyse we think this one was also probably a fluke, perhaps network related

CC @ebogo1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants