Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log depth skin workaround #8958

Merged
merged 7 commits into from
Jun 15, 2020
Merged

Conversation

baothientran
Copy link
Contributor

@baothientran baothientran commented Jun 15, 2020

Fixes #6447
Fixes #6416

I tested it using model miner.glb (#8875) and bear_on_balloon.gltf (#6416)

@cesium-concierge
Copy link

Thanks for the pull request @baothientran!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@baothientran baothientran requested a review from lilleyse June 15, 2020 16:47
@lilleyse
Copy link
Contributor

One of the model unit tests was failing locally. This is because we still have glTF 1.0 versions of CesiumMan in our tests and they have the unnormalized bone weights problem. In lieu of fixing the model which is complicated with glTF 1.0 I tweaked the test so that he faces the camera and the missing chunk doesn't overlap the center pixel.

For reference, this is the issue recreated in a local sandcastle:

side
front

@lilleyse
Copy link
Contributor

Thanks for the fix @baothientran, and as a result some nice code cleanup!

@lilleyse lilleyse merged commit 786c6de into master Jun 15, 2020
@lilleyse lilleyse deleted the remove-log-depth-skin-workaround branch June 15, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skinning broken with log depth Bear glTF 2.0 model is not displayed in Cesium.js v1.40 or later
3 participants