Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skinning broken with log depth #6447

Closed
bagnell opened this issue Apr 12, 2018 · 4 comments · Fixed by #8958
Closed

Skinning broken with log depth #6447

bagnell opened this issue Apr 12, 2018 · 4 comments · Fixed by #8958

Comments

@bagnell
Copy link
Contributor

bagnell commented Apr 12, 2018

Using log depth when skinning shows artifacts.
image
The current model implementation has a workaround until it is fixed. To see the issue, remove the two lines here.

@bagnell
Copy link
Contributor Author

bagnell commented Apr 30, 2018

Babylon.js has the same issue. I think it's an issue with the model.

BabylonJS/Babylon.js#4240

@emackey
Copy link
Contributor

emackey commented Apr 30, 2018

I'm not convinced it's an issue with the model, because it only happens when Log Depth is enabled.

@emackey
Copy link
Contributor

emackey commented Apr 30, 2018

Update: It is indeed believed to be the fault of the model, for not having normalized bone weights. See KhronosGroup/glTF#1213 (comment)

@lilleyse
Copy link
Contributor

Also came up in #8875 with this model: miner.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants