Timeline destroy cleanup #874
Merged
+225
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Properly implement Timeline destroy to make sure everyting cleans up after itself 2. Add a sanity check spec that creates/destroys the Timeline as a stopgap until we write complete specs. 3. Fix a bug introduced in #870 that caused the Timeline to not redraw properly on scroll/zoom. This change does not attempt to fix the myriad of other issues with the Timeline, so please don't review it with our normal rigor. I'm hoping to carve out some time soon to finally get around to #754.
|
@shunter we should get this in sooner rather than later because of 3 above. |
|
Looks good. Fixes the bug. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does not attempt to fix the myriad of other issues with the Timeline, so please don't review it with our normal rigor. I'm hoping to carve out some time soon to finally get around to #754.