-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Timeline to meet coding standards. #754
Comments
1. Properly implement Timeline destroy to make sure everyting cleans up after itself 2. Add a sanity check spec that creates/destroys the Timeline as a stopgap until we write complete specs. 3. Fix a bug introduced in #870 that caused the Timeline to not redraw properly on scroll/zoom. This change does not attempt to fix the myriad of other issues with the Timeline, so please don't review it with our normal rigor. I'm hoping to carve out some time soon to finally get around to #754.
What's the plan here? We obviously don't have enough time for a full re-write before 1.0; but should we just pretty up what we have with knockout and documentation? Or do we just keep what we have and have a breaking change isolated to |
I'm open to anything, but perhaps we push the whole thing unless @emackey has time to do knockout/doc before 1.0. |
Any update? Are we pushing this? |
I think the consensus is to push it and just make it a full-on breaking change later; however we should probably add at least basic doc stating as much. I'll take a stab at it tomorrow and push this after I open the pull. |
While the Timeline will be completely re-written in the future, we should have at least minor doc for 1.0 (though most things have been marked private). CC #754
I opened the above PR with very basic doc; but otherwise I'm moving this to push. |
+1 |
Some discussion on the fourm |
Thanks Matt. There's also an issue with mousewheel: when you can scroll the page Cesium is on, you can't mousewheel the timeline because the page scrolling moves the timeline away from the pointer, and the pointer needs to be hovering over the element to register mousewheel (for keyboard events only focus is needed, not hover over.) So when the timeline is hovered over page scrolling should be disabled (which seems to already be the case for the 3D canvas.) |
+1 A standalone application would be ideal... |
idea from the forum: add a way to select the current date/time by typing it in or pick from a calendar instead of having to use the slider |
@hpinkos I had the same issue and used bootstrap's datepicker to create a solution:
|
This is unlikely to be a priority anytime soon. If someone does want to address it, something along the lines of #10876 would be more in line with current coding standards. |
The
Timeline
widget is awesome and people love it; however, it's some of the oldest UI code in Cesium and is radically different than the rest of the code base. We need to bring it up to snuff so that it meets our coding standards. There are also additional features we would like to add but cannot do so until we have a way to validate andRelated issues: #773, #1768, #2066, #3555
The text was updated successfully, but these errors were encountered: