Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE crash #8701

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Fix IE crash #8701

merged 2 commits into from
Mar 26, 2020

Conversation

lilleyse
Copy link
Contributor

#8684 broke ground atmosphere rendering in IE. After some investigation it looks like the cause is a faulty GLSL implementation.

This old commit helped me out: 28d15df.

Needs to be merged before April 1.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

OmarShehata commented Mar 26, 2020

I can't seem to reproduce a crash in IE11 in master. This is my IE version:

image

I am comfortable merging this pre-computed version though given this was something we had intentionally fixed the same way when we ran into before.

The failing test on Travis is succeeding locally. I can't seem to restart the Travis build myself though.

@lilleyse
Copy link
Contributor Author

The failing test on Travis is succeeding locally. I can't seem to restart the Travis build myself though.

I can't restart it either...

@OmarShehata OmarShehata merged commit bf91215 into master Mar 26, 2020
@OmarShehata OmarShehata deleted the fix-ie branch March 26, 2020 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants