Don't hardcode WGS84 in shaders #8684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
lilleyse
force-pushed
the
ellipsoid-radii-non-wgs84
branch
from
67417e4
to
ba865ea
Compare
|
Thanks @lilleyse , can confirm this fixes the two issues. Code and tests all look good to me. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8683
Fixes #7124
The first bug is related to the depth plane being too large because
czm_ellipsoidInverseRadiiwas hardcoded to WGS84. Sandcastle.The second bug is related to ground atmosphere also hardcoding WGS84 but in a different way. For best results you should still tweaks the near and far fade distance to more closely match the ellipsoid. Sandcastle.