Ensure Cesium is fast by default #8548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. As per offline discussion, set `useBrowserRecommendedResolution` to true by default because otherwise many laptops and mobile devices with underpowered GPUs and high resolution screens run at an unusable FPS. 2. Cesium now creates a WebGL context with a `powerPreference` value of `high-performance` to provide a hint to the browser that we would prefer to use the descrete GPU if it is available.
|
Thanks for the pull request @mramato!
Reviewers, don't forget to make sure that:
|
|
LGTM. Anyone need to check anything in particular before we merge? |
|
Works on my dual-GPU mac. Tested with Chrome Canary (81.0.4029.0). |
|
@lilleyse What about Safari? I think "not at all" default to low-power there. |
|
I got inconsistent results for Safari, all modes seemed to be low-power, but maybe I was doing something wrong. |
gberaudo
pushed a commit
to swisstopo/swissgeol-viewer-app
that referenced
this pull request
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per offline discussion, set
useBrowserRecommendedResolutionto true by default because otherwise many laptops and mobile devices with underpowered GPUs and high resolution screens run at an unusable FPS.Cesium now creates a WebGL context with a
powerPreferencevalue ofhigh-performanceto provide a hint to the browser that we would prefer to use the descrete GPU if it is available.CC @kring @lilleyse
Fixes #8543