Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unflag es6 Node >= 13.2.0 #8541

Closed
wants to merge 1 commit into from
Closed

unflag es6 Node >= 13.2.0 #8541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gulp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"flags": {
"gulpfile": "gulpfile.cjs"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What looks for this file? Is it a gulp thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they added it a few versions back.

2 changes: 1 addition & 1 deletion Specs/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"overrides": [
{
"files": [
"karma.conf.js"
"karma.conf.cjs"
],
"parserOptions": {
"sourceType": "script"
Expand Down
0 Specs/karma.conf.js → Specs/karma.conf.cjs
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions gulpfile.js → gulpfile.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ if (/\.0$/.test(version)) {
version = version.substring(0, version.length - 2);
}

var karmaConfigFile = path.join(__dirname, 'Specs/karma.conf.js');
var karmaConfigFile = path.join(__dirname, 'Specs/karma.conf.cjs');
var travisDeployUrl = 'http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/';

//Gulp doesn't seem to have a way to get the currently running tasks for setting
Expand Down Expand Up @@ -101,7 +101,7 @@ var filesToConvertES6 = ['Source/**/*.js',
'!Source/Workers/cesiumWorkerBootstrapper.js',
'!Source/Workers/transferTypedArrayTest.js',
'!Specs/karma-main.js',
'!Specs/karma.conf.js',
'!Specs/karma.conf.cjs',
'!Specs/spec-main.js',
'!Specs/SpecList.js',
'!Specs/TestWorkers/**'
Expand Down