-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unflag es6 Node >= 13.2.0 #8541
Conversation
Thanks for the pull request @TJKoury!
Reviewers, don't forget to make sure that:
|
"flags": { | ||
"gulpfile": "gulpfile.cjs" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What looks for this file? Is it a gulp thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they added it a few versions back.
This issue is causing the problem: [requizzle with Node > 10].(hegemonic/requizzle#6) Updating JSDoc to @latest to include latest version of requizzle throws multiple errors. Renaming or converting /Tools/cesium_template/publish.js does not play nice with current version of JSDoc. |
I would love to know the motivation behind this massive breaking change in Node 13. For now I think we may just have to wait for everyone else to play catchup until all of our own dependencies work properly. |
@mramato That seems to be the prudent approach. I will monitor and update as appropriate. |
Thanks again for your contribution @TJKoury! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with |
Apparently 12.16 (possible 12.10 and later) also have this issue now. |
Just read the other thread. |
Going to close this and reopen. |
A few changes required for using with Node >= 13.2.0.