Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unflag es6 Node >= 13.2.0 #8541

Closed
wants to merge 1 commit into from
Closed

Conversation

TJKoury
Copy link
Contributor

@TJKoury TJKoury commented Jan 15, 2020

A few changes required for using with Node >= 13.2.0.

@cesium-concierge
Copy link

Thanks for the pull request @TJKoury!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Jan 15, 2020

Thanks @TJKoury, I assume this fixes #8452?

"flags": {
"gulpfile": "gulpfile.cjs"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What looks for this file? Is it a gulp thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they added it a few versions back.

@TJKoury
Copy link
Contributor Author

TJKoury commented Jan 15, 2020

This issue is causing the problem: [requizzle with Node > 10].(hegemonic/requizzle#6)

Updating JSDoc to @latest to include latest version of requizzle throws multiple errors.

Renaming or converting /Tools/cesium_template/publish.js does not play nice with current version of JSDoc.

@TJKoury
Copy link
Contributor Author

TJKoury commented Jan 15, 2020

@mramato It does appear to be the same issue as #8452.

@mramato
Copy link
Contributor

mramato commented Jan 17, 2020

I would love to know the motivation behind this massive breaking change in Node 13.

For now I think we may just have to wait for everyone else to play catchup until all of our own dependencies work properly.

@TJKoury
Copy link
Contributor Author

TJKoury commented Jan 17, 2020

@mramato That seems to be the prudent approach. I will monitor and update as appropriate.

@cesium-concierge
Copy link

Thanks again for your contribution @TJKoury!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@mramato
Copy link
Contributor

mramato commented Mar 1, 2020

Apparently 12.16 (possible 12.10 and later) also have this issue now.

@TJKoury
Copy link
Contributor Author

TJKoury commented Mar 1, 2020

Just read the other thread.

@TJKoury
Copy link
Contributor Author

TJKoury commented Mar 4, 2020

Going to close this and reopen.

@TJKoury TJKoury closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants