Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain back face culling option #8470

Merged
merged 4 commits into from
Dec 19, 2019
Merged

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Dec 18, 2019

Fixes #7266

Adds globe.backFaceCulling to support viewing terrain from below the surface. There will be a follow up PR for disabling skirts, a few other PRs after that for camera controls, and then ultimately an "Underground" Sandcastle example.

Local sandcastle

culling-enabled
culling-disabled

@lilleyse lilleyse requested a review from IanLilleyT December 18, 2019 00:20
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

CHANGES.md Outdated Show resolved Hide resolved
@OmarShehata
Copy link
Contributor

Cool! Make sure to close #7266 once this is merged.

@lilleyse
Copy link
Contributor Author

Thanks @OmarShehata.

@IanLilleyT can you review and merge?

@lilleyse
Copy link
Contributor Author

CC @fredj @gberaudo

@IanLilleyT IanLilleyT merged commit c6fde0d into master Dec 19, 2019
@IanLilleyT
Copy link
Contributor

Looks good to me, thanks @lilleyse

@IanLilleyT IanLilleyT deleted the terrain-back-face-culling branch December 19, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "backFaceCulling" option to Globe
4 participants