Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove precise terrain height json #8293

Merged
merged 5 commits into from
Oct 16, 2019
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Oct 15, 2019

Replaces #8244

As @mramato said in #8244, we can either fetch this file from our commit history or generate a new precise one when we need to.

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

We should remove the optimizeApproximateTerrainHeights gulp task as well since then we'll just have a task that doesn't work without reverting this file from our commit history.

@hpinkos
Copy link
Contributor Author

hpinkos commented Oct 16, 2019

That makes sense @OmarShehata
Ready

@OmarShehata
Copy link
Contributor

One more eslint error. Looks like we can get rid of the gulpJsonTransform library as well.

@OmarShehata OmarShehata merged commit 6361718 into master Oct 16, 2019
@OmarShehata OmarShehata deleted the remove-approximate-terrain-file branch October 16, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants