Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include approimateTerrainHeightsPrecise in built Cesium #8244

Closed
wants to merge 1 commit into from

Conversation

OmarShehata
Copy link
Contributor

While reviewing #8224 I noticed we were including approimateTerrainHeightsPrecise.json into the Build folder. This is not a big deal because it doesn't actually get included, it just adds half a megabyte to the zip file.

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Oct 3, 2019

Why was this file kept around at all? Since we generate this file directly from terrain data, we can just generate the more compact version directly the next time we do it. CC @tfili @hpinkos

@OmarShehata
Copy link
Contributor Author

This was the original PR #7959 where we kept the original file because (at least I) thought we didn't have a documented process of regenerating the original numbers.

I can just remove the precise version and the gulp task that regenerates it to some given degree of precision if our process for generating this file is outside this repo.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 3, 2019

@mramato yeah, this file wasn't deleted in case we needed to regenerate the values for approximateTerrainHeights at a different precision

@mramato
Copy link
Contributor

mramato commented Oct 3, 2019

@tfili has a node script that does this, but it relies on some non-public data coming from CWT. So we should document the process (even if it requires some private data), and make sure the script outputs less precise numbers (which should be trivial). For now, I would recommend just deleting the precise version and script and writing up an issue (it's in git history if we ever really need it). Hopefully Fili can chime in with more details.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 3, 2019

We have an issue open already: #6557

@tfili
Copy link
Contributor

tfili commented Oct 3, 2019

Not much to it. Run the bin/generateMinMax.js script in the generateMinMax branch of agi-node-terrain. It could probably use a merge of master and an update to new syntax. I think you just point it at the terraindb and let it run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants