Fix rhumb triangulation across IDL #8206
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8042
This is the same fix @shehzan10 added in #8176, but attempts to account for when the polygon positions cross the IDL for the projection into 2D for triangulation. It makes the assumption that if adjacent polygon positions are greater than 180 degrees away, it must be because that position crossed the IDL and it adds
TWO_PI
to the longitude. I think this is a safe assumption because Cesium can't triangulate polygons that are larger than half the earth anyway. I honestly couldn't figure out a better way to do this, but I'm open to suggestions if anyone has one. I originally wanted to useRectangle.fromCartesianArray
to get the "west" edge but that doesn't handle the case where a polygon crosses both the IDL and the prime meridian.TODO