Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GeoJSON Polygon Overlapping problem #8176

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Conversation

shehzan10
Copy link
Member

Thanks @hpinkos for the suggestion - Using the cartographic points instead of projecting to tangent plane fixed the overlap.

This was caused by the triangulation detecting that a polygon was inside rather than outside the boundary.

Fixes #8042.

@cesium-concierge
Copy link

Thanks for the pull request @shehzan10!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@hpinkos
Copy link
Contributor

hpinkos commented Sep 18, 2019

Flawless PR, thanks @shehzan10! This one is a little difficult to unit test, but the fix is not likely to get reverted by accident so I'm going to merge this.

@hpinkos hpinkos merged commit b97488a into CesiumGS:master Sep 18, 2019
@shehzan10 shehzan10 deleted the fix-8042 branch September 18, 2019 20:02
@hpinkos hpinkos mentioned this pull request Sep 20, 2019
1 task
hpinkos pushed a commit that referenced this pull request Sep 20, 2019
@hpinkos hpinkos mentioned this pull request Sep 20, 2019
hpinkos pushed a commit that referenced this pull request Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeoJSON renders incorrectly with default Rhumb arc type
3 participants