Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3D Tiles Performance Regression #7482

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Fix 3D Tiles Performance Regression #7482

merged 2 commits into from
Jan 14, 2019

Conversation

lilleyse
Copy link
Contributor

Fixes #7474

The problem was related to IBL and model shaders getting regenerated every frame. Fixed by adding equality checks in the setters.

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@lilleyse lilleyse requested a review from bagnell January 11, 2019 23:12
@OmarShehata
Copy link
Contributor

Just documenting, another failure on:

 Scene/Scene
    ✗ raises the cameraMoveEvent event when the camera stops moving
	Expected 0 to be 1.
	<Jasmine>
	@Specs/Scene/SceneSpec.js:1107:43
	window.it/<@Specs/customizeJasmine.js:76:30
	<Jasmine>

I restarted the build.

@mramato
Copy link
Contributor

mramato commented Jan 14, 2019

Looks good to me, @bagnell can you merge if happy?

@bagnell bagnell merged commit 6f82029 into master Jan 14, 2019
@bagnell bagnell deleted the fix-ibl-regression branch January 14, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants