-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#6674 rename functions #7170
#6674 rename functions #7170
Conversation
Thank you so much for the pull request @Rikku-x! I noticed this is your first pull request and I wanted to say welcome to the Cesium community! The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Thanks @Rikku-x! Can you send us a Contributor's Licence Agreement so we can review this? See instructions here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla |
@Rikku-x I didn't see your CLA come over yet. We need that before we can review your pull request. Let me know if you have any questions! If I don't hear from you by next week I'm going to close this pull request, but we can re-open it again later if you're able to get back to it. Thanks =) |
hey @hpinkos! Just send you CLA, please check it. Let me know if it is ok now :) |
Thanks again for contributing, @Rikku-x, we received your CLA. |
Thanks again for your contribution @Rikku-x! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
@OmarShehata can you review this? |
Looks great @Rikku-x ! There's a couple of failing tests which I think should be fixed if you merge in the latest Since it's a private class no change to |
Thanks @Rikku-x! Thanks for reviewing @OmarShehata! |
fix #6674
rename ApproximateTerrainHeights & getInstanceBoundingSphere functions