Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6674 rename functions #7170

Merged
merged 1 commit into from
Dec 27, 2018
Merged

#6674 rename functions #7170

merged 1 commit into from
Dec 27, 2018

Conversation

Rikku-x
Copy link
Contributor

@Rikku-x Rikku-x commented Oct 19, 2018

fix #6674

rename ApproximateTerrainHeights & getInstanceBoundingSphere functions

@cesium-concierge
Copy link

Thank you so much for the pull request @Rikku-x! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Oct 22, 2018

Thanks @Rikku-x! Can you send us a Contributor's Licence Agreement so we can review this? See instructions here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla

@hpinkos
Copy link
Contributor

hpinkos commented Nov 8, 2018

@Rikku-x I didn't see your CLA come over yet. We need that before we can review your pull request.
See instructions here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#contributor-license-agreement-cla

Let me know if you have any questions! If I don't hear from you by next week I'm going to close this pull request, but we can re-open it again later if you're able to get back to it. Thanks =)

@Rikku-x
Copy link
Contributor Author

Rikku-x commented Nov 12, 2018

hey @hpinkos!

Just send you CLA, please check it. Let me know if it is ok now :)

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 12, 2018

Thanks again for contributing, @Rikku-x, we received your CLA.

@cesium-concierge
Copy link

Thanks again for your contribution @Rikku-x!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Dec 12, 2018

@OmarShehata can you review this?

@OmarShehata
Copy link
Contributor

Looks great @Rikku-x ! There's a couple of failing tests which I think should be fixed if you merge in the latest master in your branch. If you do that I think it should be good.

Since it's a private class no change to CHANGES.md is needed.

@hpinkos
Copy link
Contributor

hpinkos commented Dec 27, 2018

Thanks @Rikku-x! Thanks for reviewing @OmarShehata!

@hpinkos hpinkos merged commit 4d4ac38 into CesiumGS:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename ApproximateTerrainHeights functions
5 participants