Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ApproximateTerrainHeights functions #6674

Closed
pjcozzi opened this issue Jun 9, 2018 · 0 comments · Fixed by #7170
Closed

Rename ApproximateTerrainHeights functions #6674

pjcozzi opened this issue Jun 9, 2018 · 0 comments · Fixed by #7170
Labels
cleanup good first issue An opportunity for first time contributors

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 9, 2018 •
edited by hpinkos
Loading

To make the names more precise and less redundant:

  • Rename ApproximateTerrainHeights.getApproximateTerrainHeights to ApproximateTerrainHeights.getMinimumMaximumHeights
  • Rename ApproximateTerrainHeights.getInstanceBoundingSphere to ApproximateTerrainHeights.getBoundingSphere

@ggetz trivial and only used internally but perhaps a good beginner issue for Omar.

CC #6617
@pjcozzi pjcozzi added cleanup good first issue An opportunity for first time contributors labels Jun 9, 2018
Rikku-x added a commit to Rikku-x/cesium that referenced this issue Oct 19, 2018
@Rikku-x
CesiumGS#6674 rename ApproximateTerrainHeights functions
9daba86
@Rikku-x Rikku-x mentioned this issue Oct 19, 2018
Merged
hpinkos pushed a commit that referenced this issue Dec 27, 2018
Merge pull request #7170 from Rikku-x/rename_functions
4d4ac38 
#6674 rename functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6674 rename functions Rikku-x/cesium
1 participant
@pjcozzi