Deprecate all the things! #6368
Conversation
Remove `loadArrayBuffer`, `loadBlob`, `loadImage`, `loadJson`, `loadJsonp`, `loadText`, `loadXML` and `loadWithXhr` have been removed. Please use the equivalent `fetch` functions on the `Resource` class. Remove `proxy`, `headers` and `query` parameters from all the fuctions that take a `Resource`. Fixes #6119
|
@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time. I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
Just realized that none of the tests were moved into Resource, @tfili am I right that I need to move all of the |
|
Okay, I added back the relevant tests and this is ready. (Still ~2700 lines down!) Not all the tests needed to be moved because they were duplicating stuff that was already tested. In the future we can definitely streamline the Resource tests further, but that's purely for cleanup purposes. |
|
It looks like you got everything outlined in the issue. Thanks @mramato. |
Didn't see anyone tackling this and the release is a week away (plus I know how to party on a Friday night).
loadArrayBuffer,loadBlob,loadImage,loadJson,loadJsonp,loadText,loadXMLandloadWithXhrhave been removed.proxy,headersandqueryparameters from all the fuctions that take aResource.Fixes #6119