Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated properties from the adding of the Resource class #6119

Closed
33 tasks
tfili opened this issue Jan 15, 2018 · 3 comments
Closed
33 tasks

Remove deprecated properties from the adding of the Resource class #6119

tfili opened this issue Jan 15, 2018 · 3 comments

Comments

@tfili
Copy link
Contributor

tfili commented Jan 15, 2018 •
edited
Loading

Remove functions:

  • loadImage
  • loadArrayBuffer
  • loadblob
  • loadImageViaBlob
  • loadJson
  • loadJsonp
  • loadText
  • loadWithXhr
  • loadXML

Removed deprecation of parameters:

  • loadCRN
  • loadKTX
  • ArcGisMapServerImageryProvider
  • BingMapsImageryProvider
  • GoogleEarthEnterpriseMapsProvider
  • GoogleEarthEnterpriseImageryProvider
  • MapboxImageryProvider
  • SingleTileImageryProvider
  • UrlTemplateImageryProvider
  • WebMapServiceImageryProvider
  • WebMapTileServiceImageryProvider
  • createOpenStreetMapImageryProvider
  • createTileMapServiceImageryProvider
  • ImageryProvider
  • CesiumTerrainProvider
  • GoogleEarthEnterpriseTerrainProvider
  • GoogleEarthEnterpriseMetadata
  • Model
  • Cesium3DTileset
  • CzmlDataSource
  • KmlDataSource

Resource class cleanup

  • loadImage method - allowCrossOrigin parameter.
  • createIfNeeded method can probably have the options parameter removed. It was there to more easily handle URL strings with a bunch of options specified to the parent classes instead of the to the Resource. Removing all these deprecated properties should remove the need for it.
  • Move all the specs for the load* functions to the specs for the Resource class.
@tfili tfili mentioned this issue Feb 9, 2018
Closed
mramato added a commit that referenced this issue Mar 24, 2018
@mramato
Deprecate all the things!
dfef80b 
Remove `loadArrayBuffer`, `loadBlob`, `loadImage`, `loadJson`, `loadJsonp`,
`loadText`, `loadXML` and `loadWithXhr` have been removed. Please use the
equivalent `fetch` functions on the `Resource` class.

Remove `proxy`, `headers` and `query` parameters from all the fuctions
that take a `Resource`.

Fixes #6119
@mramato mramato mentioned this issue Mar 24, 2018
Merged
@thw0rted
Copy link
Contributor

@tfili you closed this but createOpenStreetMapImageryProvider still takes a string for the URL, meaning you can't load it through a proxy. I can open a separate issue if you like.

@tfili
Copy link
Contributor Author

tfili commented Sep 3, 2019

@thw0rted Just looking at it quickly, I think it should work if you pass a Resource instance in as the url. It should just be a documentation tweak, if you want to write up an issue or open a PR.

@thw0rted
Copy link
Contributor

thw0rted commented Sep 4, 2019

Looks like somebody beat you to it in #8079. Maybe @ProjectBarks would like to update the docs to match the fixes he made? I'll drop a comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thw0rted @tfili