Disable clip plane shader code in IE, update docs #6079
Conversation
|
@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
|
Looks good and models work again in IE, thanks! |
| @@ -844,7 +844,7 @@ define([ | |||
| var hasColorStyle = defined(colorStyleFunction); | |||
| var hasShowStyle = defined(showStyleFunction); | |||
| var hasPointSizeStyle = defined(pointSizeStyleFunction); | |||
| var hasClippedContent = defined(clippingPlanes) && clippingPlanes.enabled && content._tile._isClipped; | |||
| var hasClippedContent = defined(clippingPlanes) && clippingPlanes.enabled && content._tile._isClipped && !FeatureDetection.isInternetExplorer(); | |||
There was a problem hiding this comment.
Maybe this check could be centralized somewhere? ClippingPlaneCollection.isSupported?
For reference: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Scene/ClassificationPrimitive.js#L340-L348
| @@ -340,7 +340,7 @@ define([ | |||
| * @param {Number} [options.colorBlendAmount=0.5] Value used to determine the color strength when the <code>colorBlendMode</code> is <code>MIX</code>. A value of 0.0 results in the model's rendered color while a value of 1.0 results in a solid color, with any value in-between resulting in a mix of the two. | |||
| * @param {Color} [options.silhouetteColor=Color.RED] The silhouette color. If more than 256 models have silhouettes enabled, there is a small chance that overlapping models will have minor artifacts. | |||
| * @param {Number} [options.silhouetteSize=0.0] The size of the silhouette in pixels. | |||
| * @param {ClippingPlaneCollection} [options.clippingPlanes] The {@link ClippingPlaneCollection} used to selectively disable rendering the model. | |||
| * @param {ClippingPlaneCollection} [options.clippingPlanes] The {@link ClippingPlaneCollection} used to selectively disable rendering the model. Clipping planes are not currently supported in Internet Explorer. | |||
There was a problem hiding this comment.
Sort of a side note, but can you list this option in Model.fromGltf as well?
There was a problem hiding this comment.
Add warning to ModelGraphics.
|
@lilleyse do you want me to hold up the release for your comments? |
|
No need, my comments aren't critical. |
|
@lilleyse Thanks, I will address those in another PR. |
CC #6077
Disable clip plane shader code from generating in IE, updated docs and Sandcastle examples to reflect this.
Should I add tests to check that the code is not generated in IE, or is that not necessary?