Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Models Sandcastle - shader linker error in IE #6077

Closed
pjcozzi opened this issue Jan 2, 2018 · 6 comments
Closed

3D Models Sandcastle - shader linker error in IE #6077

pjcozzi opened this issue Jan 2, 2018 · 6 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2018

This is blocking the 1.41 release; this works in 1.40.

http://localhost:8080/Apps/Sandcastle/index.html?src=3D Models.html&label=All

image

Works in other browsers.

@ggetz @lilleyse?

@lilleyse
Copy link
Contributor

lilleyse commented Jan 2, 2018

The demo works for me in IE. Version 11.64.16299.0.

@ggetz
Copy link
Contributor

ggetz commented Jan 2, 2018

I also cannot duplicate in IE 11.0

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 2, 2018

Thanks for looking.

This is IE 11.0.96 on Windows 7 with auto updates. I will check NVIDIA drivers.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 2, 2018

Updated to 386.01 driver for NVIDIA Quadro K2100m - linking still fails - this is likely the IE version.

We could still ship 1.41, but I don't know how widely used this version of IE is. What is new with the generated glTF shaders between 1.40 and 1.41? Is something from clipping planes included even when that are not enabled? Did gltf-pipeline change how shaders are generated from PBR materials?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 2, 2018

Discussed offline with @lilleyse. Will just disable the clipping plane code when generating shaders for 3D Models and the Globe, and comment in the Sandcastle example and reference doc that clipping planes are not currently supported in IE.

CC @ggetz

@ggetz
Copy link
Contributor

ggetz commented Jan 2, 2018

Updated in #6079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants