Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with the latest version of Node 6.x instead of 4.3 #5617

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Jul 11, 2017

eslint or one of the modules it depends on no longer works on 4.3 (we should have always just been using 4 instead of 4.3 to begin with.)

We should merge this ASAP since all branches are currently broken.

CC @ggetz @tfili

mramato added 2 commits July 11, 2017 19:18
`eslint` or one of the modules it depends on does not work on 4.3 (we
should have always just been using `4` instead of `4.3` to begin with.)
@mramato
Copy link
Contributor Author

mramato commented Jul 11, 2017

Hmm, this still failed on the newer 4 (I could only reproduce locally on 4.3). I tried bumping to 6 to see if that fixes it (6 is the current LTS anyway).

@mramato
Copy link
Contributor Author

mramato commented Jul 12, 2017

This should be good to go.

@mramato mramato changed the title Build with the latest version of Node 4.x instead of 4.3 Build with the latest version of Node 6.x instead of 4.3 Jul 12, 2017
@hpinkos
Copy link
Contributor

hpinkos commented Jul 12, 2017

👍

@hpinkos hpinkos merged commit e019a33 into master Jul 12, 2017
@hpinkos hpinkos deleted the fix-master branch July 12, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants