Cesium3DTilesInspector attaches to first tileset on hover #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggetz
changed the title
mramato
reviewed
Jul 11, 2017
CHANGES.md
Outdated
| * Fixed documentation for `OrthographicFrustum`. [#5586](https://github.com/AnalyticalGraphicsInc/cesium/issues/5586) | ||
| * Added behavior to `Cesium3DTilesInspector` that selects the first tileset hovered over if no tilest is specified. [#5139](https://github.com/AnalyticalGraphicsInc/cesium/issues/5139) |
There was a problem hiding this comment.
This needs to go in a new 1.36 section.
mramato
reviewed
Jul 11, 2017
CHANGES.md
Outdated
| @@ -6,7 +6,9 @@ Change Log | |||
| * This is an npm-only release to fix an issue with using Cesium in Node.js. | |||
| * Fixed a bug where Cesium would fail to load under Node.js and some webpack configurations. [#5593](https://github.com/AnalyticalGraphicsInc/cesium/issues/5593) | |||
| * Fixed a bug where a Model's compressed textures were not being displayed. [#5596](https://github.com/AnalyticalGraphicsInc/cesium/pull/5596) | |||
| * Fixed a bug where jsep was undefined when using webpack [#5593](https://github.com/AnalyticalGraphicsInc/cesium/issues/5593) | |||
There was a problem hiding this comment.
This can be removed, since it's a dupe of item 2 above.
|
@mramato Updated. Also do you know where this eslint error is coming from? I'm at a loss. |
Me too, I reran travis to see if it happens again or if it was some kind of fluke. |
Fixed in #5617, it's affecting all branches. |
|
Hover-over highlighting doesn't seem to work with these changes. |
|
Looks good, can you remove the |
|
@lilleyse Removed |
|
Thanks @ggetz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5139
Cesium3DTilesInspectorwill attach to the first tileset that is hovered over if no tileset is defined. Iftilesetis set, the behavior is disabled.