Remove floating-point texture requirement #4700
Conversation
…oating point textures aren't supported.
|
I tested this on my Galaxy S6. Most newer devices with OpenGL ES 3.0 or older devices that do not have the OES_texture_float extension will reproduce the issue. |
|
@bagnell is there anything duplicate here that can be moved to a shared private utility file? |
|
Can you also add a code comment about how this is a fallback and has some cases that are not memory efficient as we discussed offline? |
|
|
||
| offsets[i] = currentOffset; | ||
|
|
||
| if (componentDatatype !== ComponentDatatype.UNSIGNED_BYTE && packFloats) { |
There was a problem hiding this comment.
It would be cleaner to do this check outside of the loop to assign to a stride variable then here just do: currentOffset += stride;
There was a problem hiding this comment.
That would increase the memory even more. If the type is unsigned byte, we still only use one texel, but, if its a larger type, then we pack into unsigned bytes which is 4 texels.
There was a problem hiding this comment.
Not all attributes will have the same component type.
| return ''; | ||
| } | ||
|
|
||
| return 'float unpackFloat(vec4 value) \n' + |
There was a problem hiding this comment.
Should this be a czm_ function?
There was a problem hiding this comment.
I wouldn't move this because it mirrors unpackFloat. If we could use the packing/unpacking code elsewhere, I'd be OK with it. Can you think of another case where we would do something like this?
There was a problem hiding this comment.
Seems like anywhere we need to emulate float textures, but this is not important enough to hold up the release.
|
@bagnell I can do a final test and merge tomorrow morning before the release. Let me know when this is updated. |
The packing/unpacking code is similar to packing elsewhere but the only thing that would be shared is the constants. |
|
@pjcozzi This is ready unless you want me to separate out the packing code. |
|
Thanks @bagnell. Can you merge |
Add falling back to packing floats into unsigned byte texture when floating point textures aren't supported.
Fixes #4563.