Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uneeded sourcemap directive from earcut. #4169

Closed
wants to merge 1 commit into from
Closed

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Aug 3, 2016

The sourcemap directive at the bottom of earcut was giving several users problems. The simple solution is to just remove it.

Closes #4097
Fixes #4094

@chris-cooper
Copy link
Contributor

This fix doesn't work for me. This repo should repro the error, and you can hack on earcut in node_modules/cesium to test : https://github.com/PropellerAero/cesium-webpack . I found the warning remains with your fix, but goes away with #4097.

@mramato
Copy link
Contributor Author

mramato commented Aug 4, 2016

Have you brought up the issue with the webpack team? If the sourcemap isn't the problem and instead it's the UMD wrapper, it sounds like this may be triggering a bug on the webpack side of things. Another option is that the bug is in the UMB wrapper itself and it's a bug in the earcut build, in which case you might want to open an issue with minimmal reproduction with the earcut folks.

I don't have a problem working around it with #4097 in the meantime, but it would be nice to determine the root cause and have that fixed in the proper repository

@chris-cooper
Copy link
Contributor

It looks like there's already this webpack issue. One of the ideas mentioned is to pull module source code into your webpack built app rather than pre-built libraries. Earcut on NPM already publishes the source under src/earcut.js but it's not AMD. The change in #4097 is just providing the AMD boilerplate.

@mramato
Copy link
Contributor Author

mramato commented Aug 5, 2016

Thanks, I'll merge your other issue and link to this PR for more info.

@mramato mramato closed this Aug 5, 2016
@mramato mramato deleted the earcutlery branch August 5, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants