Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome dev tools loading incorrect source map (unminified build) #4094

Closed
slozier opened this issue Jul 6, 2016 · 4 comments
Closed

Chrome dev tools loading incorrect source map (unminified build) #4094

slozier opened this issue Jul 6, 2016 · 4 comments
Labels
good first issue An opportunity for first time contributors

Comments

@slozier
Copy link
Contributor

slozier commented Jul 6, 2016

The earcut library has a source mapping url in the comments

//# sourceMappingURL=data:application/json;charset=utf-8;base64,...

When loading the unminified build in the Chrome dev tools it tries to be smart and picks this up as the source mapping for Cesium.js (which obviously it isn't).
@pjcozzi pjcozzi added the good first issue An opportunity for first time contributors label Jul 6, 2016
@laurensdijkstra
Copy link

Yes I also experience this problem. Is it a bug or a possible configuration issue on my side?

mramato added a commit that referenced this issue Aug 3, 2016
@mramato
Remove uneeded sourcemap directive from earcut.
7723867 
Closes #4097
Fixes #4094
@mramato mramato mentioned this issue Aug 3, 2016
Closed
@mramato
Copy link
Contributor

mramato commented Aug 3, 2016

I just opened #4169 to fix this issue, if you have a chance to try it out and report back, that would be great. Thanks.

@slozier
Copy link
Contributor Author

slozier commented Aug 3, 2016

@mramato 👍

@laurensdijkstra
Copy link

Works for me! Clicking on a line number in an exception now gets me to the line in the Cesium.js file like it should. Breakpoints also work again.

@mramato mramato closed this as completed Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pjcozzi @laurensdijkstra @mramato @slozier