Camera clipping terrain fix #3750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Camera vectors may not be orthonormal when the camera clamps to the terrain | ||
| // so apply inverse instead of inverseTransformation | ||
| Matrix4.inverse(camera._viewMatrix, camera._invViewMatrix); |
There was a problem hiding this comment.
Is this just a band-aid? Should we apply Gram–Schmidt orthonormalization earlier so the matrix is orthonormal?
There was a problem hiding this comment.
Yes just a band-aid right now. I'll try to fix the main problem before this is ready.
There was a problem hiding this comment.
This is fine the shadows branch, but are you sure you want to put this in master now?
There was a problem hiding this comment.
@lilleyse what do you think? Should we close this?
There was a problem hiding this comment.
I'll close this and submit an issue instead.
There was a problem hiding this comment.
Or.. just keep the fog issue open.
There was a problem hiding this comment.
Let's leave the fog issue open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3178.
Also fixes the atmosphere flickering that happens when the camera is swiveled into the ground.
This fix doesn't really solve the underlying problem.
ScreenSpaceCameraController.adjustHeightForTerraingenerates non-orthonormal view vectors which causesinverseTransformationto not work as expected. I'm not completely sure how to fix that, but this is a quick fix that works at a slight computation cost.