Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tiles to tileset #3441

Merged
merged 6 commits into from
Jan 18, 2016
Merged

Rename tiles to tileset #3441

merged 6 commits into from
Jan 18, 2016

Conversation

TomPed
Copy link
Contributor

@TomPed TomPed commented Jan 18, 2016

Renamed all tiles.json to tileset.json and fixed code to use tiles.

For CesiumGS/3d-tiles#53

@lilleyse
Copy link
Contributor

Can you merge 3d-tiles into this branch? Once that is done you can also rename the function loadTilesJson to loadTileset.

@TomPed
Copy link
Contributor Author

TomPed commented Jan 18, 2016

I've renamed the function and its one use in the Cesium3DTileset class and I'm getting this error:

screen shot 2016-01-18 at 2 31 50 pm

Could this have anything to do with the mock Cesium3DTilesTester?

@lilleyse
Copy link
Contributor

I would do a global search and replace, it's in a few areas including Cesium3DTilesetSpec.

@lilleyse
Copy link
Contributor

Could this have anything to do with the mock Cesium3DTilesTester?

Yeah it's in there too.

@TomPed
Copy link
Contributor Author

TomPed commented Jan 18, 2016

Find and replace worked good, 👍.

lilleyse added a commit that referenced this pull request Jan 18, 2016
@lilleyse
Merge pull request #3441 from TomPed/rename-tiles-to-tileset
321cf9b 
Rename tiles to tileset
@lilleyse lilleyse merged commit 321cf9b into CesiumGS:3d-tiles Jan 18, 2016
@lilleyse lilleyse deleted the rename-tiles-to-tileset branch January 18, 2016 19:47
@lilleyse
Copy link
Contributor

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomPed @lilleyse