Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tiles.json to tileset.json #53

Merged
merged 4 commits into from
Jan 15, 2016
Merged

Rename tiles.json to tileset.json #53

merged 4 commits into from
Jan 15, 2016

Conversation

pjcozzi
Copy link
Contributor

@pjcozzi pjcozzi commented Jan 15, 2016

Merge #52 first.

Fixes #49.

@TomPed can you make the corresponding code change in Cesium? Make sure to rename the tiles.json files used in the tests.

@@ -8,7 +8,7 @@ Contents:
* [Spec status](#spec-status)
* [Introduction](#introduction)
* [Tile metadata](#tile-metadata)
* [tiles.json](#tilesjson)
* [tileset.json](#tilesjson)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should #tilesjson be #tileset.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@TomPed
Copy link

TomPed commented Jan 15, 2016

How would I know which README.md file these changes are to be made?

@lilleyse
Copy link
Contributor

The README.md changes I mentioned are for this repo only (the 3D tiles spec), so you don't have to worry about them.

@TomPed
Copy link

TomPed commented Jan 15, 2016

Got it.

When I search for tiles.json a lot of files show up am I to change them all?

@lilleyse
Copy link
Contributor

Yeah you can change them all.

@TomPed
Copy link

TomPed commented Jan 15, 2016

I will also change the file tiles2.json to tileset2.json and tiles3.json to tileset3.json

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 15, 2016

Updated links.

lilleyse added a commit that referenced this pull request Jan 15, 2016
@lilleyse lilleyse merged commit 3bd3911 into master Jan 15, 2016
@lilleyse
Copy link
Contributor

Merged.

@pjcozzi pjcozzi deleted the tileset-json branch March 3, 2016 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants