CZML model node transformations #3316
Conversation
…gular property so that it adheres to any interval specified in the model packet.
…ditional transformations from czml
…to specify if glTF animations should be started
Rename to `NodeTransformation` to match CZML. Create new `PropertyBag` class that allows for notification of changes of properties added with `addProperty`.
|
With Greg's help, I put together an Sandcastle example that shows this working. var viewer = new Cesium.Viewer('cesiumContainer');
viewer.dataSources.add(Cesium.CzmlDataSource.load('https://gist.githubusercontent.com/shunter/08c95fcebb1c3506530a/raw/09805419206c60eea4cf8948c056a92ae29b15c8/satellite.czml')).then(function(dataSource) {
viewer.trackedEntity = dataSource.entities.getById('Satellite/Satellite2');
}); |
|
It would be nice to include a CZML example for this in Sandcastle like the other CZML examples. Also, I was not planning on reviewing this unless there is something in particular you guys want me to look at. Also, do you guys want to write a short tech blog post on CZML/glTF interop? There would be interest from the Cesium and glTF communities. |
|
For the sandcastle example, I figure we probably don't want to commit the 4MB gltf file from STK referenced in my previous example above. Let me know if you think this is too dumb looking for a demo. I wanted to make the transformations visually obvious. |
|
I don't think users will realize that the example is correct. Perhaps just spin the Cesium Milk truck 360 degrees - or if you really want to emphasize the "we're referencing a node id, not the entire model aspect", @lilleyse could create a simple model with two nodes for this. |
|
Yeah, I think we need to emphasize that it affects nodes, and not the whole model (spinning a whole model is trivial without any of these changes). I'm happy to use a different model instead. |
|
What about raising and lowering the body of the milk truck, like if someone was changing the suspension? Or maybe rotating the wheels of the truck to look like a turn? |
| * @param {Cartesian3} [translation=Cartesian3.ZERO] A {@link Cartesian3} specifying the (x, y, z) translation to apply to the node. | ||
| * @param {Quaternion.IDENTITY} [rotation=Quaternion.IDENTITY] A {@link Quaternion} specifying the (x, y, z, w) rotation to apply to the node. | ||
| */ | ||
| var NodeTransformation = function(scale, translation, rotation) { |
There was a problem hiding this comment.
I understand why this is in DataSources, but it certainly looks like something I would except to be in Core. Are we sure that we're never going to need something like this at the lower level?
There was a problem hiding this comment.
Core is probably a better choice. Probably name it Transform, AffineTransform, or TranslationRotationScale.
Throughout, the parameters should also be in that order: translation, rotation, scale. TRS, as it is called, is common in graphics and what we say in glTF.
There was a problem hiding this comment.
OK, renamed to TranslationRotationScale and moved to Core.
…e. Make PropertyBag take a result parameter in its getValue function.
|
regarding node transformations, I put together a sandcastle demo that allows direct manipulation of node transforms in the UI. http://shunter.github.io/modelNodes/3D%20Model%20Node%20Explorer.html you can make Cesium Man do a little dance for you by rotating joints. I'm thinking this could be useful to go into the development directory. opinions? |
|
The development directory is OK, but most developers using models would be interested in this so I would suggest putting it in the main Sandcastle examples. |
|
There will also be a separate CZML example, right? |
|
I left the Model Node Explorer example in the development section because 1) it does not use the entity API and 2) it uses private Cesium members (it's not possible to enumerate model nodes in the public API). I also added the CZML example. Cesium Man says hello: http://shunter.github.io/nodeTransformations/CZML%20Model%20-%20Node%20Transformations.html |
|
Amazing. |
|
Also, as soon as this is merged and @gbeatty's exporter is updated, we are going to replace the C4ISR example from the website with an awesome model-based simulation. I also want to look into making a separate space-based example, perhaps with the IIS or maneuvering satellites. |
|
We totally need a demo of the Cesium man doing the robot ;) |
| var defaultRotation = Quaternion.IDENTITY; | ||
|
|
||
| /** | ||
| * A set of transformations to apply to a particular node in a {@link Model}. |
There was a problem hiding this comment.
This is kind of more generic now, right? @pjcozzi do you have a suggestion for a one-line definition of TRS?
There was a problem hiding this comment.
An affine transformation defined by a translation, rotation, and scale.
Add `Matrix4.fromTranslationRotationScale`. Remove `TranslationRotationScale.prototype.toMatrix` Tweak documentation Get rid of empty function Update tests.
…sformations CZML model node transformations
This builds on top of Greg's changes in #3003 and includes all of them.
I'm opening this for initial review, though I still need to add some additional tests.
czml-writer pr: AnalyticalGraphicsInc/czml-writer#102
This adds support for time-varying model node transformations in CZML. A
NodeTransformationaggregatesscale,translationandrotationas values.NodeTransformationPropertyproducesNodeTransformationvalues from properties.ModelGraphicsnow hasnodeTransformationswhich is a newPropertyBagobject, which is a key-value store for properties, includingdefinitionChangedpropagation.PropertyBagmay be useful for eventually supporting custom CZML properties.