-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model node transformations and other improvements #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formation for the individual properties
This reverts commit b5b77fe.
Add support for "additionalProperties" in jsonschema which indicates the schema for any property in a scope. This is now used to generate writers for the key-value pair style of CZML for node transformations. Also dropped nextTime/previousTime from jsonschema, which was never actually supported.
…Allow booleans to be references.
shunter
added a commit
that referenced
this pull request
Dec 3, 2015
…ransform Model node transformations and other improvements
This was referenced Dec 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #101 including all of Greg's changes, and additionally starts working towards wrangling this mess of a project into shape.
CZML now supports the general concept of key-value data, for example:
This is generated by specifying "additionalProperties" in the jsonschema, which essentially associates structure with any property, rather than naming specific CZML properties. jsonschema allows for constraining the name of additional properties, but for this use case this is unnecessary.
Along the way I significantly refactored the GenerateFromSchema code. I also took a pass through the existing schema and fixed and improved documentation in a number of places. The concept of nextTime/previousTime has never been supported, and has been removed. Interpolation/extrapolation-related properties were not documented and have been added. The "axes" property on orientation has never been supported, and has been removed. Boolean properties were not allowed to be references, which was an oversight, and has been corrected.
For completeness, additional CZML changes from Greg's PR include a Boolean property
runAnimations
to control whether animations run on load.