-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webgl2 #3094
Merged
Merged
Webgl2 #3094
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9b5c7c0
Create webgl2 context
lilleyse 0f6a5b9
Fix webgl extensions that are now core
lilleyse 9100963
Do not use the index of the max value of an unsigned short. Fixing te…
bagnell 946b9b5
Update Context tests but it looks like OES_standard_derivatives and E…
bagnell e887a4b
Disable problematic extensions.
bagnell 7aadb33
Organization changes
lilleyse 3d0d05f
Merge remote-tracking branch 'lilleyse/webgl2' into webgl2
lilleyse 9eada79
Fix instancing tests.
bagnell 6880345
Fix more tests and fix polyline collections indices.
bagnell 0e9e069
Fix frag depth test.
bagnell b98bdb4
Set defaultToWebgl2 to false
lilleyse e459999
Minor updates from review.
bagnell 7c75a12
More updates from review.
bagnell 6e75213
Fix jsHint errors.
bagnell ac691a5
Tweak comments
pjcozzi da9eb87
More updates from review.
bagnell 74e1a44
Fix jsHint errors.
bagnell 5fc31cc
Check if instanced arrays are supported in draw test.
bagnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather only assign to each context property once since I'm not 100% sure that all JavaScript engines will optimize (not enter dictionary mode) when we "create" properties in a branch (even though it is in both branches).
Instead, perhaps something like:
Or leave it if someone can confirm the performance.