Webgl2 #3094

lilleyse · 2015-10-14T22:30:52Z

Added preliminary WebGL2 support. Fixed any incompatibilities between WebGL1 extensions and WebGL2 core, though there are a few extensions that aren't supported right now.

…sts WIP.

…XT_frag_depth aren't supported.

bagnell · 2015-10-14T22:35:32Z

OES_standard_derivatives is disabled. dFdx, dFdy and fwidth are not recognized when compiling the shader.
EXT_frag_depth is disabled. gl_FragDepth is not recognized when compiling the shader (neither is gl_FragDepthEXT).
OES_texture_float is disabled. Could not create a texture with PixelDatatype.FLOAT.
WEBGL_depth_texture is disabled. Could not attach a depth-stencil texture to a FBO.

bagnell · 2015-10-14T22:36:57Z

There should be one test failure for materials because the PolylineArrowMaterial uses standard derivatives.

pjcozzi · 2015-10-14T22:42:26Z

@bagnell I added your comments to #797 (comment)

bagnell · 2015-10-14T22:44:02Z

Also changes indices to not use the maximum value of the index type. The maximum value of the index type is used for primitive restart. It may also be beneficial for WebGL 1.0 when using ANGLE.

pjcozzi · 2015-10-14T22:44:18Z

Source/Core/TerrainProvider.js

@@ -104,8 +104,8 @@ define([
     */
    TerrainProvider.getRegularGridIndices = function(width, height) {
        //>>includeStart('debug', pragmas.debug);
-        if (width * height > 64 * 1024) {
-            throw new DeveloperError('The total number of vertices (width * height) must be less than or equal to 65536.');
+        if (width * height >= 64 * 1024) {


We should also change COLLADA2GLTF and any terrain tools that break up meshes to use 64K - 1 vertices, right?

I guess use CesiumMath.SIXTY_FOUR_KILOBYTES here (and anywhere else) like we do elsewhere.

We should also change COLLADA2GLTF and any terrain tools that break up meshes to use 64K - 1 vertices, right?

Right, split them or use unsigned ints.

@tfili @abwood see note above about using 64K - 1 vertices when splitting meshes.

We are good for models.

Why minus 1? You can fit exactly 64k vertices using unsigned short and the comparison is checking the vertex count, not the max index.

pjcozzi · 2015-10-14T22:56:34Z

There are JSHint errors: https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/85431116

pjcozzi · 2015-10-14T22:56:44Z

Good start to WebGL 2. Just those comments.

bagnell · 2015-10-15T02:27:14Z

@pjcozzi This is ready for another review.

pjcozzi · 2015-10-15T13:54:58Z

@abwood see the WebGL 2 spec:

5.18 PRIMITIVE_RESTART_FIXED_INDEX is always enabled

The PRIMITIVE_RESTART_FIXED_INDEX context state, controlled with Enable/Disable in OpenGL ES 3.0, is not supported in WebGL 2.0. Instead, WebGL 2.0 behaves as though this state were always enabled. This is a compatibility difference compared to WebGL 1.0.

When drawElements, drawElementsInstanced, or drawRangeElements processes an index, if the index's value is the maximum for the data type (255 for UNSIGNED_BYTE indices, 65535 for UNSIGNED_SHORT, or 4294967295 for UNSIGNED_INT), then the vertex is not processed normally. Instead, it is as if the drawing command ended with the immediately preceding vertex, and another drawing command is immediately started with the same parameters, but only transferring the immediately following index through the end of the originally specified indices.

This compatibility difference was introduced in order to avoid performance pitfalls in Direct3D based WebGL implementations. Applications and content creation tools can be adjusted to avoid using the maximum vertex index if the primitive restart behavior is not desired.

pjcozzi · 2015-10-15T14:04:20Z

Source/Renderer/Context.js

        ContextLimits._maximumTextureFilterAnisotropy = defined(textureFilterAnisotropic) ? gl.getParameter(textureFilterAnisotropic.MAX_TEXTURE_MAX_ANISOTROPY_EXT) : 1.0;
+
+        if (webgl2) {


I'd rather only assign to each context property once since I'm not 100% sure that all JavaScript engines will optimize (not enter dictionary mode) when we "create" properties in a branch (even though it is in both branches).

Instead, perhaps something like:

var glCreateVertexArray = undefined; if (webgl2) { glCreateVertexArray = // ... } else { glCreateVertexArray = // ... } this.glCreateVertexArray = glCreateVertexArray;

Or leave it if someone can confirm the performance.

pjcozzi · 2015-10-15T14:06:04Z

Looks good. Just that comment.

bagnell · 2015-10-15T15:17:03Z

@pjcozzi This is ready.

pjcozzi · 2015-10-15T15:19:18Z

With WebGL 1, I get this when opening the CZML Sandcastle example (and perhaps others):

pjcozzi · 2015-10-15T15:19:50Z

JSHint is also failing: https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/85552141

bagnell · 2015-10-15T15:29:38Z

@pjcozzi The jsHint errors are fixed. Fixing them fixed getting the extensions in WebGL 1.0.

pjcozzi · 2015-10-15T15:48:09Z

WebGL 1 looks good.

On WebGL 2 in Canary, should this test fail?

Renderer/Draw draws two instances of a point with different per-instance colors
DeveloperError: instanced arrays is not supported
Error
    at new DeveloperError (http://localhost:8080/Source/Core/DeveloperError.js:43:19)
    at addAttribute (http://localhost:8080/Source/Renderer/VertexArray.js:62:19)
    at new VertexArray (http://localhost:8080/Source/Renderer/VertexArray.js:288:13)
    at http://localhost:8080/Specs/Renderer/DrawSpec.js:1113:14
    at Object.<anonymous> (http://localhost:8080/Specs/spec-main.js:137:30)
    at attemptAsync (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1793:24)
    at QueueRunner.run (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1746:26)
    at QueueRunner.execute (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1732:10)
    at Spec.Env.queueRunnerFactory (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:620:35)
    at Spec.execute (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:357:10)

bagnell · 2015-10-15T16:39:56Z

@pjcozzi I wasn't seeing that failure but it should be fixed.

pjcozzi · 2015-10-15T17:04:59Z

Looks good!

pjcozzi · 2015-10-15T17:05:11Z

Thanks @bagnell and @lilleyse!

Webgl2

lilleyse and others added 11 commits October 13, 2015 20:10

Create webgl2 context

9b5c7c0

Fix webgl extensions that are now core

0f6a5b9

Do not use the index of the max value of an unsigned short. Fixing te…

9100963

…sts WIP.

Update Context tests but it looks like OES_standard_derivatives and E…

946b9b5

…XT_frag_depth aren't supported.

Disable problematic extensions.

e887a4b

Organization changes

7aadb33

Merge remote-tracking branch 'lilleyse/webgl2' into webgl2

3d0d05f

Fix instancing tests.

9eada79

Fix more tests and fix polyline collections indices.

6880345

Fix frag depth test.

0e9e069

Set defaultToWebgl2 to false

b98bdb4

pjcozzi mentioned this pull request Oct 14, 2015

WebGL 2 and WebGL Extensions Roadmap #797

Closed

22 tasks

pjcozzi reviewed Oct 14, 2015
View reviewed changes

bagnell added 3 commits October 14, 2015 19:55

Minor updates from review.

e459999

More updates from review.

7c75a12

Fix jsHint errors.

6e75213

pjcozzi reviewed Oct 15, 2015
View reviewed changes

Tweak comments

ac691a5

More updates from review.

da9eb87

Fix jsHint errors.

74e1a44

Check if instanced arrays are supported in draw test.

5fc31cc

pjcozzi added a commit that referenced this pull request Oct 15, 2015

Merge pull request #3094 from lilleyse/webgl2

6d8700e

Webgl2

pjcozzi merged commit 6d8700e into CesiumGS:master Oct 15, 2015

pjcozzi deleted the webgl2 branch October 15, 2015 17:05

bagnell mentioned this pull request Nov 16, 2017

IndexDatatype uses Uint32Array when numberOfVertices==65536 #5983

Open

sanjeetsuhag mentioned this pull request Nov 2, 2022

Using WebGL 2 by default #10887

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webgl2 #3094

Webgl2 #3094

lilleyse commented Oct 14, 2015

bagnell commented Oct 14, 2015

bagnell commented Oct 14, 2015

pjcozzi commented Oct 14, 2015

bagnell commented Oct 14, 2015

pjcozzi Oct 14, 2015

pjcozzi Oct 14, 2015

bagnell Oct 14, 2015

pjcozzi Oct 14, 2015

tfili Oct 14, 2015

abwood Oct 15, 2015

pjcozzi commented Oct 14, 2015

pjcozzi commented Oct 14, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

pjcozzi Oct 15, 2015

pjcozzi commented Oct 15, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

		ContextLimits._maximumTextureFilterAnisotropy = defined(textureFilterAnisotropic) ? gl.getParameter(textureFilterAnisotropic.MAX_TEXTURE_MAX_ANISOTROPY_EXT) : 1.0;

		if (webgl2) {

Webgl2 #3094

Webgl2 #3094

Conversation

lilleyse commented Oct 14, 2015

bagnell commented Oct 14, 2015

bagnell commented Oct 14, 2015

pjcozzi commented Oct 14, 2015

bagnell commented Oct 14, 2015

pjcozzi Oct 14, 2015

Choose a reason for hiding this comment

pjcozzi Oct 14, 2015

Choose a reason for hiding this comment

bagnell Oct 14, 2015

Choose a reason for hiding this comment

pjcozzi Oct 14, 2015

Choose a reason for hiding this comment

tfili Oct 14, 2015

Choose a reason for hiding this comment

abwood Oct 15, 2015

Choose a reason for hiding this comment

pjcozzi commented Oct 14, 2015

pjcozzi commented Oct 14, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

pjcozzi Oct 15, 2015

Choose a reason for hiding this comment

pjcozzi commented Oct 15, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

bagnell commented Oct 15, 2015

pjcozzi commented Oct 15, 2015

pjcozzi commented Oct 15, 2015