Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve KML compatibility with Google Earth and fix a few bugs. #2539

Merged
merged 3 commits into from
Mar 3, 2015
Merged

Improve KML compatibility with Google Earth and fix a few bugs. #2539

merged 3 commits into from
Mar 3, 2015

Commits on Mar 3, 2015

  1. Fix KML loading crash due to an empty <ExtendedData> node. 

    Thanks to @GatorScott for some sample KML files that triggered this.
    @mramato
    mramato committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    2e65eb2 View commit details
    Browse the repository at this point in the history

  2. Support KML TimeStamp and non-spec compliant local styles 

    In #873, @GatorScott found a bunch of KML files that either didn't work
or didn't match Google Earth.  Turns out that Google Earth handles
local styles that do not start with a `#` sign, which is not spec compliant.
Since our goal is to match Google Earth, we now process these styles
properly rather than spitting out a warning/error.

We were also missing support for the TimeStamp element, which was an
oversight on my part.

The above changes make all KML files on http://activefiremaps.fs.fed.us/googleearth.php
work properly (though they require a proxy).
    @mramato
    mramato committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    1b44401 View commit details
    Browse the repository at this point in the history

  3. Update CHANGES

    @mramato
    mramato committed Mar 3, 2015
    Configuration menu
    Copy the full SHA
    2c945de View commit details
    Browse the repository at this point in the history