Improve KML compatibility with Google Earth and fix a few bugs. #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @GatorScott for some sample KML files that triggered this.
In #873, @GatorScott found a bunch of KML files that either didn't work or didn't match Google Earth. Turns out that Google Earth handles local styles that do not start with a `#` sign, which is not spec compliant. Since our goal is to match Google Earth, we now process these styles properly rather than spitting out a warning/error. We were also missing support for the TimeStamp element, which was an oversight on my part. The above changes make all KML files on http://activefiremaps.fs.fed.us/googleearth.php work properly (though they require a proxy).
pjcozzi
added a commit
that referenced
this pull request
Mar 3, 2015
Improve KML compatibility with Google Earth and fix a few bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #873, @GatorScott found a bunch of KML files that either didn't work or didn't match Google Earth. Turns out that Google Earth handles local styles that do not start with a
#sign, which is not spec compliant. Since our goal is to match Google Earth, we now detect and process these styles rather than spitting out a warning/error.We were also missing support for the
TimeStampelement, which was an oversight on my part.Also fixed a KML loading crash when we encountered an empty node and no description text, this was a straight up bug on our end.
The above changes make all KML files on http://activefiremaps.fs.fed.us/googleearth.php work properly (though they require a proxy). I also added tests for everything.