Refactor julian date #1821
Merged
Refactor julian date #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn all prototype functions (except for clone/equals/eqaulsEpsilon/compareTo) into static functions.
Default constructing a JulianDate no longer creates an instance set to the current time; I added JulianDate.now() for this purpose.
1. Clean up documentation. 2. Make all relevant function take result parameters.
Conflicts: Source/DynamicScene/SampledProperty.js
1. Removes the need for circular referneces between `LeapSecond` and `JulianDate`. 2. Moves array of leap seconds from `LeapSecond.leapSeconds` to `JulianDate.leapSeconds`
…nDate.getDaysDifference
| * CZML property references now use a `#` symbol to separate identifier from property path. `objectId.position` should now be `objectId#position`. | ||
| * `CesiumWidget.showErrorPanel` now takes a `message` parameter in between the previous `title` and `error` parameters. | ||
| * `Event.removeEventListener` no longer throws `DeveloperError` if the `listener` does not exist; it now returns `false`. | ||
| * Moved `LeapScond.leapSeconds` to `JulianDate.leapSeconds`. |
|
CC #1407 |
| */ | ||
| JulianDate.prototype.addMinutes = function(duration) { | ||
| JulianDate.addMinutes = function(julianDate, minutes) { |
There was a problem hiding this comment.
This and the other addX functions don't actually have the result parameter that they are documented as having.
Actually take a result parameter in function that claim to.
|
All pending issues have been taken care of. |
Conflicts: CHANGES.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LeapSecond.leapSecondstoJulianDate.leapSeconds.JulianDateto be in line with other Core types.JulianDate.now()instead.JulianDate.getJulianTimeFractionandJulianDate.compareTonew JulianDate()->JulianDate.now()date.getJulianDayNumber()->date.dayNumberdate.getSecondsOfDay()->secondsOfDaydate.getTotalDays()->JulianDate.getTotalDays(date)date.getSecondsDifference(arg1, arg2)->JulianDate.getSecondsDifference(arg2, arg1)(Note, order of arguments flipped)date.getDaysDifference(arg1, arg2)->JulianDate.getDaysDifference(arg2, arg1)(Note, order of arguments flipped)date.getTaiMinusUtc()->JulianDate.getTaiMinusUtc(date)date.addSeconds(seconds)->JulianDate.addSeconds(date, seconds)date.addMinutes(minutes)->JulianDate.addMinutes(date, minutes)date.addHours(hours)->JulianDate.addHours(date, hours)date.addDays(days)->JulianDate.addDays(date, days)date.lessThan(right)->JulianDate.lessThan(left, right)date.lessThanOrEquals (right)->JulianDate.lessThanOrEquals (left, right)date.greaterThan (right)->JulianDate.greaterThan (left, right)date.greaterThanOrEquals (right)->JulianDate.greaterThanOrEquals (left, right)