Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JulianDate, TimeInterval and TimeIntervalCollection #1407

Closed
3 tasks done
pjcozzi opened this issue Jan 24, 2014 · 4 comments
Closed
3 tasks done

Refactor JulianDate, TimeInterval and TimeIntervalCollection #1407

pjcozzi opened this issue Jan 24, 2014 · 4 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 24, 2014

  • JulianDate
  • TimeInterval
  • TimeIntervalCollection
@pjcozzi
Copy link
Contributor Author

pjcozzi commented May 1, 2014

@mramato what is the scope for this? Is this something @hpinkos can help us with?

@mramato
Copy link
Contributor

mramato commented May 6, 2014

The scope is a bit unknown and it's a pretty big change. I'm okay with @hpinkos working on it, but I need to take the time and figure out exactly what the gameplan is first. I'm hoping to do this sooner rather than later.

@pjcozzi pjcozzi added the 1.0 label May 8, 2014
@mramato mramato changed the title Refactor TimeInterval and TimeIntervalCollection Refactor JulianDate, TimeInterval and TimeIntervalCollection Jun 9, 2014
@mramato
Copy link
Contributor

mramato commented Jun 9, 2014

I started to look into this and I'm going to start with a pull request to just refactor JulianDate. It's going to follow the same strategy as our other Core types, that is; I will remove most prototype functions, there will be no private variables, all operations will take result parameters, etc..

Additionally, I may remove a few functions that are not being used (for example addHours), and make some functions private or move them to somewhere else (for exmaple getTaiMinusUtc).

Anyone have any thoughts on this before I start? CC @kring @shunter

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jun 20, 2014

@mramato can we close this?

@mramato mramato closed this as completed Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants