Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JulianDate.getSecondsDifference consistency #1253

Closed
pjcozzi opened this issue Oct 21, 2013 · 5 comments
Closed

JulianDate.getSecondsDifference consistency #1253

pjcozzi opened this issue Oct 21, 2013 · 5 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 21, 2013

Given that Cartesian3.subtract(a, b) is a - b, shouldn't a.getSecondsDifference(b) also be a - b? Currently, it is b - a.

@mramato
Copy link
Contributor

mramato commented Oct 21, 2013

JulianDate needs to be completely refactored to meet our current standards. It was one of the few core classes that never got transitioned over.

@andr3nun3s
Copy link
Contributor

I can pick this up if you want, just tell me what needs to be done.

@mramato
Copy link
Contributor

mramato commented Nov 26, 2013

@Andre-Nunes I think we need a larger pass on JulianDate than just this one change, so I would hold off on this for now (we aren't sure what we want to do yet, we just know it needs a lot of cleanup). If you are looking for stuff to do, there are a bunch of little issues that have been building up; off the top of my head #913 and #1299 might be a few good ones to knock off (and you'll get to learn about an area of the code you haven't worked with yet I believe).

@pjcozzi pjcozzi added the 1.0 label May 8, 2014
@pjcozzi
Copy link
Contributor Author

pjcozzi commented May 22, 2014

CC #405

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jun 10, 2014

Closing as duplicate with #1407.

@pjcozzi pjcozzi closed this as completed Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants