Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed datasource display visualizer callback typedef #11294

Merged

Conversation

bkuster
Copy link
Contributor

@bkuster bkuster commented May 18, 2023

fixes the type of DataSourceDisplay.VisualizersCallback to correctly inlcude EntityCluster

@cesium-concierge
Copy link

Thanks for the pull request @bkuster!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor

ggetz commented May 18, 2023

Perfect, thanks @bkuster!

@ggetz ggetz merged commit afab16d into CesiumGS:main May 18, 2023
ggetz added a commit that referenced this pull request May 25, 2023
…ed" syntax (#11271)

* Fix `Color.fromCssColorString` in case of parsing `rgb(a)`/`hsl(a)` CSS colors with modern "space-separated" syntax

* Add `Alexander Popoff` (@aerialist7) to the list of contributors

* Escaping

* Disable `/` parsing

* Fix regexps

* Only remove surrounding whitespace from color strings

* Enable `/` parsing

* Formatting

* Make sure availability tiles are loaded before deciding there is no terrain at that x, y, level

* Return the correct promise

* Update CHANGES.md

* Adjust camera controls for 3D

* Use first picked position in drag when possible

* Use pick position direction for panning

* Only use new camera controls when globe is false

* Spin3d should fallback to old behavior when globe is defined

* pick globe on spin3d

* Fallback to old behavior for spin3d

* Updates for Google Photorealistic 3D Tiles

* Updates for 1.105.1 release

* Fix doc for Entity.prototype.computeModelMatrix (#11277)

Co-authored-by: Jeshurun Hembd <[email protected]>

* Update widgets version

* fixed datasource display visualizer callback typedef (#11294)

* Add TextureUniform type for setUniform value type (#11284)

* Add unit test

* Enable standard derivatives extension in demodernizeShader

* Update CHANGES.md

---------

Co-authored-by: Gabby Getz <[email protected]>
Co-authored-by: Jeshurun Hembd <[email protected]>
Co-authored-by: Jeshurun Hembd <[email protected]>
Co-authored-by: Ben Kuster <[email protected]>
Co-authored-by: Frédéric Junod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants