Fix docstring in Entity
#11277
Merged
Fix docstring in Entity
#11277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @jjhembd!
Reviewers, don't forget to make sure that:
|
|
Thanks @jjhembd! |
ggetz
added a commit
that referenced
this pull request
May 25, 2023
…ed" syntax (#11271) * Fix `Color.fromCssColorString` in case of parsing `rgb(a)`/`hsl(a)` CSS colors with modern "space-separated" syntax * Add `Alexander Popoff` (@aerialist7) to the list of contributors * Escaping * Disable `/` parsing * Fix regexps * Only remove surrounding whitespace from color strings * Enable `/` parsing * Formatting * Make sure availability tiles are loaded before deciding there is no terrain at that x, y, level * Return the correct promise * Update CHANGES.md * Adjust camera controls for 3D * Use first picked position in drag when possible * Use pick position direction for panning * Only use new camera controls when globe is false * Spin3d should fallback to old behavior when globe is defined * pick globe on spin3d * Fallback to old behavior for spin3d * Updates for Google Photorealistic 3D Tiles * Updates for 1.105.1 release * Fix doc for Entity.prototype.computeModelMatrix (#11277) Co-authored-by: Jeshurun Hembd <[email protected]> * Update widgets version * fixed datasource display visualizer callback typedef (#11294) * Add TextureUniform type for setUniform value type (#11284) * Add unit test * Enable standard derivatives extension in demodernizeShader * Update CHANGES.md --------- Co-authored-by: Gabby Getz <[email protected]> Co-authored-by: Jeshurun Hembd <[email protected]> Co-authored-by: Jeshurun Hembd <[email protected]> Co-authored-by: Ben Kuster <[email protected]> Co-authored-by: Frédéric Junod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSDoc for
Entity.prototype.computeModelMatrixincorrectly stated that the result would beundefinedif the entity's orientation was undefined. The method actually assumes a default orientation if none was specified.This PR corrects the doc