-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old b3dm/i3dm/pnts content classes #10635
Conversation
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
@j9liu I checked the Sandcastles and they're all good except for the ones with the BIM model (since that change is only on |
@j9liu okay, the Sandcastles with the BIM tileset should work correctly now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptrgags looks good for the most part, just a few comments!
I'll run through the Sandcastles locally as well to make sure no new bugs came up
@j9liu oops forgot to mention the PR is ready for review again! |
I found a regression but I don't think it has to hold up this PR. In the 3D Tiles Formats sandcastle, For reference, this is what it does on sandcastle.com right now: Everything else looks good. Thanks @ptrgags ! |
As part of #10346, this PR removes
Batched3DModel3DTileContent
,Instanced3DModel3DTileContent
andPointCloud3DTileContent
.Model3DTileContent
will be used instead.A couple of notes:
ModelExperimental
handle classification #10623 will handle thisCesium3DTileBatchTable
until we can consolidate that withModelFeatureTable
, since the tests usedb3dm
files which no longer use the old style of batch table (only.vctr
and.geom
do)@j9liu could you review?