-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ModelExperimental
handle classification
#10623
Conversation
Thanks for the pull request @j9liu!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j9liu a couple initial comments for now, most notably that many tests are failing at least on Linux.
d302692
to
679453d
Compare
@ptrgags updated with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j9liu The classification model is working nicely! And I can confirm that this Sandcastle is now working again.
I had a few comments/questions before we merge
Specs/Scene/ModelExperimental/DequantizationPipelineStageSpec.js
Outdated
Show resolved
Hide resolved
Source/Scene/ModelExperimental/ClassificationModelDrawCommand.js
Outdated
Show resolved
Hide resolved
Source/Scene/ModelExperimental/ClassificationModelDrawCommand.js
Outdated
Show resolved
Hide resolved
Just for good measure, I tried swapping out the model in your Sandcastle example with other models. When I try it with the
is this expected? I also tried |
@ptrgags I pushed a fix -- I didn't realize that |
I can confirm that the fix does fix things for Microcosm! |
@ptrgags updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j9liu just a couple quick things I noticed about the @experimental
tags
(I also see you pushed some commits while I was reviewing, sorry if anything overlaps 😅)
@ptrgags added the |
Looks good, thanks @j9liu! |
This PR adds support for classification models in
ModelExperimental
. This was accomplished without needing to create an equivalent ofClassificationModel
. Instead, aClassificationModelDrawCommand
is created to handle the special classification commands.Sandcastle for testing (updated for
ModelExperimental -> Model
). The tileset is clipped with a clipping plane so you can see the terrain underneath.I also found #10160 while looking through issues related to classification, and I confirmed that the sandcastle (updated for
ModelExperimental -> Model
) doesn't crash with the changes in this PR.Summary:
ClassificationModelDrawCommand
. This is modeled after the commands inVector3DTilePrimitive
.classificationType
toModelExperimental
.Model3DTileContent
now passes the classification option toModelExperimental
.ModelExperimental
specs for setting / changingclassificationType
.Model3DTileContent
with the render specs fromBatched3DModel3DTileContentClassificationSpec
.