Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty neighbor cells list detection #874

Merged
merged 2 commits into from
May 9, 2016

Conversation

pchk
Copy link
Contributor

@pchk pchk commented May 5, 2016

@agilob
Copy link
Contributor

agilob commented May 5, 2016

This is a risky change that will rise a lot of false-positives. LTE cells don't provide any neighbouring cells. My LG that I have also doesn't has such functionality of any kind of cells, it's just not supported by manufacturer on the device. Rising alarm because of such reason will be misleading and people will come here to ask if they are targeted.

@pchk
Copy link
Contributor Author

pchk commented May 5, 2016

Alert will never be shown if your phone does not support that.
Only when your phone was been able to detect some neighbor cells in the past, but after connection to new cell it does not provide any neighbors.
As for LTE cells. If so, check for connection type will be enough.

@pchk
Copy link
Contributor Author

pchk commented May 5, 2016

Check this. A think that is exactly what we need.

@SecUpwN
Copy link
Member

SecUpwN commented May 9, 2016

Approved! Thanks for this fix, @pchk! @Nordlenning, have a look after I merged this. We need some extensive testing, it would be lovely if you could assist and report back in #264. @He3556 since you actually opened #264, please be so kind and test the now bleeding edge APK from Buildozer as well!

Approved with PullApprove

@SecUpwN SecUpwN merged commit d72d37b into CellularPrivacy:development May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants