Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check BTS for the NC List [$50] #264

Closed
He3556 opened this issue Jan 7, 2015 · 18 comments
Closed

Check BTS for the NC List [$50] #264

He3556 opened this issue Jan 7, 2015 · 18 comments

Comments

@He3556
Copy link
Collaborator

He3556 commented Jan 7, 2015

If the "unsupported flag" (see #100 (comment)) is not set, we still need to check if every BTS is providing a NC (Neighboring Cell) list. The NC list is used to provide information to the cell phone to select a new antenna if there is an antenna with better signal reception than the currently connected one. But the cell phone doesn't need to scan or connect to all BTSs to get this info and saves energy.

Our code is already reading the NC list with API calls and other methods. But there might be some phones that do not support this (like many Samsungs), so there will be an empty list. If the list is empty, then we need to set the unsupported flag=1. In the logcat you see when the phone is polling for the information. And on the menu you see the NC list under Cell Information, on those phones providing it.

If the flag = 0 and the NC list of the currently connected Cell is empty, then we have a positive detection of a suspicious BTS. Most IMSI-catchers doesn't provide an NC list or they manipulate it. (Finding manipulations will be the next task to test for.) In particular, if we find a cell-id (CID) that is not in the OCID DB, this check is important. Thus we should run this test immediately.

There is a $5 open bounty on this issue. Add to the bounty at Bountysource.

@E3V3A
Copy link
Contributor

E3V3A commented Jan 13, 2015

Clarified issue OP text.

@Ueland
Copy link
Contributor

Ueland commented Jan 13, 2015

Hmm, this might be a bit hard for me to implement when my device always complains about no neighboring cells. Or perhaps i should add the "is supported"-detection?

Any ideas on where in code we should add this? (It`s own class or as a part of one of the others?)

@He3556
Copy link
Collaborator Author

He3556 commented Jan 13, 2015

The updateNeighbouringCells() is in the CellTracker.java line 348 From there you can have a look how it is working now. I think we can set the flag in this code. But where to save it? And we should check it again from time to time, so we are absolutely sure that it is the device that is not supporting the list.

@He3556
Copy link
Collaborator Author

He3556 commented Jan 13, 2015

In CellTracker.java, see "void setNotification()"
line 706 (and the notifications are set. We need to add another tickertext into the case "MEDIUM":

pseudo code:

if (NoNCL)  {
     contentText = "The Cell " + cellid + " is not providing a neighboring cell list!";
 }

... for example

@E3V3A
Copy link
Contributor

E3V3A commented Jan 13, 2015

@He3556 That last comment is rather cryptic. Can you clarify? (And link to the code using <url>#Lnnn-NNN.)

@E3V3A
Copy link
Contributor

E3V3A commented Jan 17, 2015

BTW. What is MEDIUM there? We should label them with the color codes we already have documented.

@He3556
Copy link
Collaborator Author

He3556 commented Jan 22, 2015

It means Medium Alert. That is in the code and i don't want to change it without a clear concept.
If you start changing it here, you had to change it on many places in the code. Then we need to test again and find all the new bugs and so on...
And it is not important for the one who will implement it.

@E3V3A
Copy link
Contributor

E3V3A commented Jan 22, 2015

We're not changing anything, we're just sticking to what we already documented , and which make programming more transparent.

@He3556
Copy link
Collaborator Author

He3556 commented Jan 31, 2015

i have an idea of a fast implementation of this. If a NC List is (of a GSM Tower) is present we set the property "NC-list present" to "1". If there is a tower without NC List and the value is "1" we have a detection. I will try to implement this and test it also, asap.

@E3V3A
Copy link
Contributor

E3V3A commented Feb 1, 2015

This is a very good idea. But the flag as you describe it above should probably be implemented in the DBi_measure table. The other flag (NC list) unsupported flag in #100 in this diagram, is referring to HW/SW support as described in #235.

@He3556
Copy link
Collaborator Author

He3556 commented Feb 1, 2015

Yes why not. We can add the value "NC-list present" into the DBi_measure table. But than we need a query to see if the last BTS provided a list. If we have a property it is always the same check. So less possibilities of errors. And the DBi_measure table will be growing over the time. Could be faster to use a simple check of "NC-list present" value.

@E3V3A
Copy link
Contributor

E3V3A commented Feb 1, 2015

Sorry, then I don't understand what you mean with "property". Where is this property stored and how many are we talking about? For me a property is getprop.

@He3556
Copy link
Collaborator Author

He3556 commented Feb 1, 2015

we just need one value for that. If there is another place for saving a boolean let's do it somewhere else. We don't save our configuration (preferences or flags) in the db, or did this change the last days? Many things happened, it's hard to follow the changes.

@SecUpwN SecUpwN changed the title Check BTS for the NC List Check BTS for the NC List [$5] Aug 25, 2015
@SecUpwN SecUpwN added the bounty label Aug 25, 2015
@SecUpwN SecUpwN changed the title Check BTS for the NC List [$5] Check BTS for the NC List [$20] Mar 23, 2016
@Nordlenning
Copy link
Member

30 USD bounty on this issue so far
https://www.bountysource.com/issues/7557508-check-bts-for-the-nc-list

@SecUpwN
Copy link
Member

SecUpwN commented Apr 6, 2016

30 USD bounty on this issue so far

Strange, I wonder why the title did not update automatically. Manually updated the thread title.

@SecUpwN SecUpwN changed the title Check BTS for the NC List [$20] Check BTS for the NC List [$30] Apr 6, 2016
@Nordlenning
Copy link
Member

THANK YOU !

@SecUpwN SecUpwN changed the title Check BTS for the NC List [$30] Check BTS for the NC List [$50] May 1, 2016
@He3556 He3556 closed this as completed May 15, 2016
@SecUpwN
Copy link
Member

SecUpwN commented May 29, 2016

@pchk, our app appears to detect a massive amount of missing neighboring cells now. Would you please be so kind and see if you can improve upon your already merged work? Thank you very much!

@pchk
Copy link
Contributor

pchk commented Jun 23, 2016

@SecUpwN hi, i was offline last month. Please can you describe in details what is wrong now? Or may be thare are some opened issues with description of problems you are mentioned in the post above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants