Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugins): add a new backend for generating JSOO wrapper #291

Merged
merged 21 commits into from
Jul 22, 2022
Merged

feat(plugins): add a new backend for generating JSOO wrapper #291

merged 21 commits into from
Jul 22, 2022

Conversation

EmileRolley
Copy link
Collaborator

@EmileRolley EmileRolley commented Jul 18, 2022 •
edited
Loading

Implementation of the issue #290.

Changelog

  • New plugin jsoo generating a js_of_ocaml wrapper around a Catala program.
  • New runtimes:
    • The OCaml runtime has been moved in ./runtimes/ocaml -- Runtime_ocaml.Runtime.
    • A new JSOO runtime is stored in ./runtimes/jsoo -- Runtime_jsoo.Runtime.
  • The To_ocaml module now exposed more functions used in To_jsoo.
  • The OCaml generated variant types are now encapsulated inside their own module like struct in feat(backend): disambiguate OCaml record names derived from Catala structs #288.
  • New function Cli.ocamlformat_file_opt which calls ocamlformat to format generated ocaml files.
  • The Makefile rule generate_french_law_library_ocmal now depends on the plugins one and generates the law_source/allocations_famililales_api_web.ml file.
  • New Makefile rule %_api_web.ml in ./examples/Makefile.common.mk to use the jsoo plugin.

@EmileRolley EmileRolley added ✨ enhancement New feature or request 🔚 backends Backend runtime or code generation labels Jul 18, 2022
@EmileRolley EmileRolley linked an issue Jul 18, 2022 that may be closed by this pull request
Feat: add a new plugin for wrapper generation from Lcalc #290
Closed
@EmileRolley EmileRolley mentioned this pull request Jul 18, 2022
Merged
@EmileRolley EmileRolley force-pushed the 290-jsoo-wrapper-plugin branch 14 times, most recently from edc595d to e687626 Compare July 22, 2022 14:06
@EmileRolley EmileRolley marked this pull request as ready for review July 22, 2022 14:29
@EmileRolley EmileRolley added the 🔧 compiler Issue concerns the compiler label Jul 22, 2022
denismerigoux
denismerigoux approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I'll merge that now.

@denismerigoux denismerigoux merged commit d266202 into master Jul 22, 2022
@EmileRolley EmileRolley mentioned this pull request Aug 2, 2022
Closed
@EmileRolley EmileRolley deleted the 290-jsoo-wrapper-plugin branch August 2, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denismerigoux denismerigoux denismerigoux approved these changes

Assignees
No one assigned
Labels
🔚 backends Backend runtime or code generation 🔧 compiler Issue concerns the compiler ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: add a new plugin for wrapper generation from Lcalc
2 participants
@EmileRolley @denismerigoux