Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): disambiguate OCaml record names derived from Catala structs #288

Merged
merged 2 commits into from
Jul 13, 2022
Merged

feat(backend): disambiguate OCaml record names derived from Catala structs #288

merged 2 commits into from
Jul 13, 2022

Conversation

EmileRolley
Copy link
Collaborator

Fixes #191.

@EmileRolley EmileRolley added ✨ enhancement New feature or request 🔚 backends Backend runtime or code generation labels Jul 12, 2022
denismerigoux
denismerigoux approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@denismerigoux denismerigoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@EmileRolley
Copy link
Collaborator Author

I'm not sure what to do for this case..

@EmileRolley EmileRolley marked this pull request as draft July 12, 2022 12:18
@EmileRolley EmileRolley marked this pull request as ready for review July 12, 2022 13:17
denismerigoux
denismerigoux approved these changes Jul 13, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@denismerigoux denismerigoux merged commit 0a0c101 into master Jul 13, 2022
@EmileRolley EmileRolley mentioned this pull request Jul 22, 2022
Merged
@denismerigoux denismerigoux deleted the 191-fix branch September 6, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denismerigoux denismerigoux denismerigoux approved these changes

Assignees
No one assigned
Labels
🔚 backends Backend runtime or code generation ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the OCaml backend's record field confusion
2 participants
@EmileRolley @denismerigoux