-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: fix export data #2141
Hotfix: fix export data #2141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcb37 So wanted to confirm one thing, you are now showing the attribute metric (timeSeconds
) instead of the class (masteryWorkspace
) for a grouped metric in the metrics column, right? Should we show the complete grouped metric (Class -> Key -> Attribute)? I have attached screenshot for other to see the difference. The old export gives 2 rows for each of the 2 students and the new one as per this PR gives 1 row for each of the 2 students. This is working perfectly as expected.
Also, didn't get the 2nd point of this PR description. Which metric column will not be shown? We already show the metrics that are used in the experiment. Can you please elaborate this scenario a bit. Thanks
Also, didn't get the 2nd point of this PR description. Which metric column will not be shown? We already show the metrics that are used in the experiment. Can you please elaborate this scenario a bit. Thanks @ppratikcr7 it was including metrics columns from other experiments because the metrics list wasn't restricted to just the metrics in the current experiment. So I fixed that. |
This pr:
MarkExperimentPointTime
values with a single row withMarkExperimentPointTime
coming from the enrollment table