-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import feature flag list feature #2071
Conversation
...ntent/feature-flag-exclusions-section-card/feature-flag-exclusions-section-card.component.ts
Outdated
Show resolved
Hide resolved
@Yagnik56 Could you please share a working FF list JSON file (or content)? |
I added 3 files in the description now, you can use those for testing. |
To fix the issue of incompatibility: |
backend/packages/Upgrade/src/api/services/FeatureFlagService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/FeatureFlagService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/FeatureFlagService.ts
Outdated
Show resolved
Hide resolved
frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts
Outdated
Show resolved
Hide resolved
@Yagnik56 Could you please reshare a JSON file content with minimal information possible? I think you mentioned many of the properties (e.g., |
@zackcl I updated the |
Here are the file contents for reference:Individual_list.json:
Group_list.json:
Segment_list.json:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes.
backend/packages/Upgrade/src/api/services/FeatureFlagService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/FeatureFlagService.ts
Outdated
Show resolved
Hide resolved
backend/packages/Upgrade/src/api/services/FeatureFlagService.ts
Outdated
Show resolved
Hide resolved
frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts
Outdated
Show resolved
Hide resolved
frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts
Outdated
Show resolved
Hide resolved
…ure-flag-list Export feature flag list modals, API endpoing and functionality
This PR contains an import feature flag list feature with validation and import endpoints.
Here are a few images of the same.
There are 3 lists json files available in zack's comment for testing with the updated format.
Some Validation user has to keep in mind:
The list's context and feature flag's context must match; all these lists have Mathia as context.
The feature flag ID isn't needed. It will be removed from export and where the list is getting imported that feature flag's ID will be added during import from the backend.
For the listType as a segment, the subsegment it refers to should exist with the same context as the feature flag we are importing that list in.
The group type has to be valid for its context with the list type available for it's context.