Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF: Import List Modal (Include and Exclude Table Menu Function) #1746

Closed
danoswaltCL opened this issue Jul 10, 2024 · 1 comment · Fixed by #2071
Closed

FF: Import List Modal (Include and Exclude Table Menu Function) #1746

danoswaltCL opened this issue Jul 10, 2024 · 1 comment · Fixed by #2071

Comments

@danoswaltCL
Copy link
Collaborator

The user can open the Include or Exclude List Table menu and select to "Import List" (only difference between these two will be the modal text)

Image

This will open a standard confirmation modal such as this one, I don't have a pic of this at the moment but the language should be:

title: Import List
message: Are you sure you want to Import a List into the Include Lists || Exclude Lists table?

@zackcl let me know if that seems right!

  • should this need validation like we do with other imports?
  • can we give the user some hint about what a valid file might look like, either with an explicit example or a link to something in gitbook?

Image

@zackcl
Copy link
Collaborator

zackcl commented Jul 12, 2024

title: Import List
message: Are you sure you want to Import a List into the Include Lists || Exclude Lists table?

I don't think we need a confirmation modal for importing lists. We would immediately show the import modal that allows uploading a single JSON file, which looks like this:

State=Default Import List

The "Import Feature Flag" modal works the same way:

Image

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: QA
Development

Successfully merging a pull request may close this issue.

4 participants